Skip to content

refactor(design-system)!: remove deprecated DsDropdownMenuLegacy and DsRadioGroupLegacy [AR-53409]#340

Merged
mmurawski-dn merged 3 commits intodrivenets:nextfrom
mmurawski-dn:drivenets/michal/AR-53409-remove-legacy-components
Apr 15, 2026
Merged

refactor(design-system)!: remove deprecated DsDropdownMenuLegacy and DsRadioGroupLegacy [AR-53409]#340
mmurawski-dn merged 3 commits intodrivenets:nextfrom
mmurawski-dn:drivenets/michal/AR-53409-remove-legacy-components

Conversation

@mmurawski-dn
Copy link
Copy Markdown
Collaborator

No description provided.

vpolessky-dn
vpolessky-dn previously approved these changes Apr 2, 2026
iromanchuk-dn
iromanchuk-dn previously approved these changes Apr 7, 2026
Copy link
Copy Markdown
Member

@StyleShit StyleShit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. are these 2 components really related? do we really need to remove them together?
  2. i think we should have changelogs here for both the DS and ESLint packages

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I did not see a reason not to do it at one go. And, if I remember correctly, it was easier to do these two (and confirm + dialog) together
  2. I will have a final clean up PR after those and I wanted to put a whole changelog there

…sRadioGroupLegacy [AR-53409]

Remove legacy implementations from DsDropdownMenu and DsRadioGroup,
their ESLint deprecation rules and tests, legacy stories, legacy SCSS,
and @radix-ui/react-dropdown-menu + @radix-ui/react-radio-group dependencies.
Replacements: DsDropdownMenu (compound), DsRadioGroup (compound)

Made-with: Cursor
@mmurawski-dn mmurawski-dn force-pushed the drivenets/michal/AR-53409-remove-legacy-components branch from 56d6b97 to 24f9ba4 Compare April 14, 2026 11:16
@StyleShit StyleShit changed the title refactor(design-system): remove deprecated DsDropdownMenuLegacy and DsRadioGroupLegacy [AR-53409] refactor(design-system)!: remove deprecated DsDropdownMenuLegacy and DsRadioGroupLegacy [AR-53409] Apr 15, 2026
@mmurawski-dn mmurawski-dn merged commit b8f4616 into drivenets:next Apr 15, 2026
17 checks passed
StyleShit pushed a commit that referenced this pull request Apr 15, 2026
StyleShit pushed a commit that referenced this pull request Apr 16, 2026
StyleShit pushed a commit that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants